Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ソング:シーケンサーの外で起こったmousemove、mouseupも拾うようにする #2317

Conversation

sigprogramming
Copy link
Contributor

内容

mousemovemouseupを、sequencerBodyではなくwindowでlistenするようにして、
シーケンサーの外で起こったmousemovemouseupも拾うようにします。

その他

@sigprogramming sigprogramming requested a review from a team as a code owner October 25, 2024 12:02
@sigprogramming sigprogramming requested review from Hiroshiba and removed request for a team October 25, 2024 12:02
Copy link
Member

@Hiroshiba Hiroshiba left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!!!

色々試してみましたが問題なさそうな挙動をしていました!!!
この変更だけで使い勝手がかなり上がると思うので、素晴らしいです!!!!!!

@Hiroshiba Hiroshiba merged commit 127bf8e into VOICEVOX:main Oct 25, 2024
8 checks passed
@sigprogramming sigprogramming deleted the make_mousemove_and_mouseup_events_listen_on_window branch October 26, 2024 10:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants